Skip to content

Add Radius.Compute/containerImages resource type in default types - #11650

Merged
willdavsmith merged 5 commits into
mainfrom
add-containerimages
Apr 16, 2026
Merged

Add Radius.Compute/containerImages resource type in default types#11650
willdavsmith merged 5 commits into
mainfrom
add-containerimages

Conversation

@willdavsmith

@willdavsmith willdavsmith commented Apr 15, 2026 •
edited by kachawla
Loading

Copy link
Copy Markdown
Contributor

Description

Please explain the changes you've made.

Type of change

  • This pull request fixes a bug in Radius and has an approved issue (issue link required).
  • This pull request adds or changes features of Radius and has an approved issue (issue link required).
  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
    • Yes
    • Not applicable

@willdavsmith
Add containerImages
e5e7423 
Signed-off-by: willdavsmith <willdavsmith@gmail.com>
@willdavsmith
willdavsmith requested review from a team as code owners April 15, 2026 18:14
Copilot AI review requested due to automatic review settings April 15, 2026 18:14
@willdavsmith
willdavsmith had a problem deploying to external-contributor-approval April 15, 2026 18:14 — with GitHub Actions Failure
kachawla
kachawla previously approved these changes Apr 15, 2026
View reviewed changes
Copilot AI reviewed Apr 15, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Radius.Compute/containerImages resource type to the built-in provider manifest so Radius Bicep can describe building/pushing container images (BuildKit-based) as part of an application.

Changes:

  • Introduces the containerImages resource type with 2025-08-01-preview schema in the dev Radius.Compute manifest.
  • Documents intended local-dev workflow and recipe registration prerequisites within the resource type description.
  • Adds schema for build and optional registry auth overrides (with token marked sensitive).

Comment thread deploy/manifest/built-in-providers/dev/radius_compute.yaml Resolved
Comment thread deploy/manifest/built-in-providers/dev/radius_compute.yaml Resolved
Comment thread deploy/manifest/built-in-providers/dev/radius_compute.yaml Resolved
@github-actions

github-actions Bot commented Apr 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Unit Tests

    2 files  ±0    415 suites  ±0   6m 45s ⏱️ +14s
4 872 tests ±0  4 870 ✅ ±0  2 💤 ±0  0 ❌ ±0 
5 774 runs  ±0  5 772 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit eff42f0. ± Comparison against base commit a7a52ae.

♻️ This comment has been updated with latest results.

@codecov

codecov Bot commented Apr 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.39%. Comparing base (a7a52ae) to head (eff42f0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11650   +/-   ##
=======================================
  Coverage   51.39%   51.39%           
=======================================
  Files         699      699           
  Lines       44111    44111           
=======================================
+ Hits        22671    22673    +2     
+ Misses      19275    19274    -1     
+ Partials     2165     2164    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@willdavsmith
add data
abd4152 
Signed-off-by: willdavsmith <willdavsmith@gmail.com>
@willdavsmith
willdavsmith had a problem deploying to external-contributor-approval April 15, 2026 18:33 — with GitHub Actions Failure
@willdavsmith
PR
fcaddba 
Signed-off-by: willdavsmith <willdavsmith@gmail.com>
@willdavsmith
willdavsmith temporarily deployed to external-contributor-approval April 15, 2026 18:39 — with GitHub Actions Inactive
kachawla
kachawla previously approved these changes Apr 15, 2026
View reviewed changes
@willdavsmith willdavsmith added the pr:standard Ongoing maintenance, minor improvements, documentation updates, and routine development work label Apr 15, 2026
@willdavsmith
PR
0a28242 
Signed-off-by: willdavsmith <willdavsmith@gmail.com>
@willdavsmith
willdavsmith temporarily deployed to external-contributor-approval April 15, 2026 21:56 — with GitHub Actions Inactive
@kachawla
kachawla temporarily deployed to external-contributor-approval April 15, 2026 23:34 — with GitHub Actions Inactive
@radius-functional-tests

radius-functional-tests Bot commented Apr 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Radius functional test overview

🔍 Go to test action run

Click here to see the test run details
Name Value
Repository radius-project/radius
Commit ref eff42f0
Unique ID funcdd5d7b9aca
Image tag pr-funcdd5d7b9aca
  • gotestsum 1.13.0
  • KinD: v0.29.0
  • Dapr: 1.14.4
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcdd5d7b9aca
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcdd5d7b9aca
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcdd5d7b9aca
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcdd5d7b9aca
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcdd5d7b9aca
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@willdavsmith
willdavsmith merged commit 1184341 into main Apr 16, 2026
56 checks passed
@willdavsmith
willdavsmith deleted the add-containerimages branch April 16, 2026 02:53
@github-actions github-actions Bot mentioned this pull request Apr 16, 2026
Closed

This branch was previously deployed

1 inactive deployment
external-contributor-approval — eff42f0d Deployed Apr 15, 2026 by kachawla via Approval Gate #8896
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@kachawla kachawla kachawla approved these changes

Assignees

No one assigned

Labels

pr:standard Ongoing maintenance, minor improvements, documentation updates, and routine development work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@willdavsmith @kachawla